Skip to content

[chores:sample_users] Added migration for OrganizationUser.is_admin#1425

Merged
nemesifier merged 1 commit into
masterfrom
fix-sample-users
Jul 7, 2026
Merged

[chores:sample_users] Added migration for OrganizationUser.is_admin#1425
nemesifier merged 1 commit into
masterfrom
fix-sample-users

Conversation

@pandafy

@pandafy pandafy commented Jul 7, 2026

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • N/A I have manually tested the changes proposed in this pull request.
  • N/A I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • N/A I have updated the documentation.

Description of Changes

Related to upstream changes in openwisp-users openwisp/openwisp-users#541

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

A test migration file is updated to include an additional schema operation altering the organizationuser model's is_admin field to a BooleanField with default=False and verbose_name="Organization manager". This operation is appended after the existing index creation operation in the same migration file.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related issues: None specified.

Related PRs: None specified.

Suggested labels: migrations, tests

Suggested reviewers: None specified.

🐰 A tiny hop, a field renamed,
"Organization manager" now proclaimed,
Boolean false, tucked in with care,
One small migration, added with flair.


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Description check ❌ Error The description is incomplete because it omits the issue reference, a real change summary, and the screenshot section. Add a Closes #issue-number reference, briefly describe the migration change, and include the Screenshot section or mark it N/A.
Changes ⚠️ Warning No targeted tests were added for the new field/index or label change; only a generic migration-graph test exists, so the change isn’t specifically validated. Add focused tests for the sample_users migration/admin behavior, or justify why the existing generic migration-graph test is sufficient; update docs only if the changed behavior is documented.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title is descriptive and matches the migration change for OrganizationUser.is_admin.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed This PR is a migration sync for sample_users, not a core user-facing bug fix, so regression-test requirements don’t apply.
Features ✅ Passed This PR is a single migration sync for OrganizationUser.is_admin, not a feature request; docs/tests/screenshots/issue validation are not applicable.
General Rules ✅ Passed The migration is a focused metadata update with no security, performance, naming, or test regressions visible in-repo.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-sample-users

Comment @coderabbitai help to get the list of available commands.

@pandafy pandafy moved this from To do (general) to Needs review in OpenWISP Contributor's Board Jul 7, 2026
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.547%. remained the same — fix-sample-users into master

@github-project-automation github-project-automation Bot moved this from Needs review to In progress in OpenWISP Contributor's Board Jul 7, 2026
@nemesifier nemesifier merged commit 4056e1b into master Jul 7, 2026
23 checks passed
@nemesifier nemesifier deleted the fix-sample-users branch July 7, 2026 16:16
@github-project-automation github-project-automation Bot moved this from In progress to Done in OpenWISP Contributor's Board Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants