Skip to content

[fix] Add PR approved checks in bot-changelog workflow#622

Merged
nemesifier merged 1 commit intoopenwisp:masterfrom
pushpitkamboj:ci/fix_bot_changelog
Mar 14, 2026
Merged

[fix] Add PR approved checks in bot-changelog workflow#622
nemesifier merged 1 commit intoopenwisp:masterfrom
pushpitkamboj:ci/fix_bot_changelog

Conversation

@pushpitkamboj
Copy link
Contributor

Checklist

Reference to Existing Issue

Closes #621

Description of Changes

added the PR approved check in changelog-bot workflow

@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2026

📝 Walkthrough

Walkthrough

The pull request adds a conditional gate to the changelog GitHub Actions workflow job. The condition requires the pull request to be approved and the reviewer to have owner, member, or collaborator association before the changelog generation workflow can execute. This prevents the bot from being triggered on non-approved pull request actions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

github_actions, helper-bots

Suggested reviewers

  • nemesifier

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error, 1 inconclusive)

Check name Status Explanation Resolution
Bug Fixes ❌ Error PR fixes root cause by adding approval gates to bot-changelog workflow but includes no regression tests to verify the fix or prevent future regressions. Add regression tests verifying workflow skips on non-approved reviews, skips on unauthorized reviewers, and runs on approved reviews from OWNER/MEMBER/COLLABORATOR.
Description check ❓ Inconclusive The description covers key sections (checklist, issue reference, description of changes) but is missing required documentation updates and test case sections, which limits completeness. Clarify whether documentation updates and new test cases were created or confirm they are not applicable for this workflow change.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR successfully implements the requirement from issue #621 by adding an approval gate to the changelog workflow that ensures the changelog bot only runs when a PR has been approved by authorized reviewers.
Out of Scope Changes check ✅ Passed All changes are scoped to the bot-changelog workflow file and directly implement the approval check requirement, with no extraneous modifications detected.
Title check ✅ Passed The title clearly describes the main change: adding PR approval checks to the bot-changelog workflow. It follows the required format [type] with 'fix' and provides a descriptive summary.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot added github_actions Pull requests that update GitHub Actions code helper-bots Helper bots, release management automation labels Mar 14, 2026
@coveralls
Copy link

Coverage Status

coverage: 97.348%. remained the same
when pulling 6b2c2e0 on pushpitkamboj:ci/fix_bot_changelog
into b1cb23b on openwisp:master.

@nemesifier nemesifier merged commit 5906760 into openwisp:master Mar 14, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code helper-bots Helper bots, release management automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci] Add PR review check

3 participants