Skip to content

luci-app-usteer: Add parameters specifically for usteer-ng#8419

Merged
systemcrash merged 1 commit intoopenwrt:masterfrom
Ramon00:add-usteer-ng-params
Mar 16, 2026
Merged

luci-app-usteer: Add parameters specifically for usteer-ng#8419
systemcrash merged 1 commit intoopenwrt:masterfrom
Ramon00:add-usteer-ng-params

Conversation

@Ramon00
Copy link
Contributor

@Ramon00 Ramon00 commented Mar 13, 2026

usteer-ng is the forked version of usteer with more options and improvements.
This commit allows setting the additional options in luci-app-usteer.

Next to that a small bug is fixed.

@Ramon00 Ramon00 changed the title luci-app-usteer: Add paramets specifically for usteer-ng luci-app-usteer: Add parameters specifically for usteer-ng Mar 13, 2026
@github-actions

This comment has been minimized.

@Ramon00 Ramon00 force-pushed the add-usteer-ng-params branch from 818c0d4 to 25c99dd Compare March 14, 2026 10:00
@systemcrash
Copy link
Contributor

The angle you're going for here is that the new settings work or are benign. How about detecting which agent is installed via a fs.stat or fs.exec command -v and revealing settings based on that result? It might prevent users lodging bug reports 'this setting doesn't work'....

@Ramon00
Copy link
Contributor Author

Ramon00 commented Mar 15, 2026

I can try to see if fs.stat works

@domingues
Copy link

usteer-ng has new default values, probably they should also be reflected here. NilsRo/usteer-ng@b69ac48

Even better is to push for the original project to wake up to life... openwrt/usteer#10

@Ramon00 Ramon00 force-pushed the add-usteer-ng-params branch 2 times, most recently from b573277 to e6d58c1 Compare March 16, 2026 18:13
@Ramon00
Copy link
Contributor Author

Ramon00 commented Mar 16, 2026

I can try to see if fs.stat works

Ok I added an elegant detection

usteer-ng has new default values

Its only 1 parameter, also i cannot really detect what the default is. The only thing I could do is check if one of the other parameters are included and then change the default based on that. But to be honest, I dont think it is that important, especially because usteer-ng is not officially supported. @systemcrash what do you think, also switch on that, or just leave it slightly less complex?

@systemcrash
Copy link
Contributor

Well, you can elide a default for the parameter, and retain whatever value is provided, especially if it's a flag.

We can put this in and see how it fares. master only?

@Ramon00 Ramon00 force-pushed the add-usteer-ng-params branch from 2934a93 to cf30bda Compare March 16, 2026 22:06
@Ramon00
Copy link
Contributor Author

Ramon00 commented Mar 16, 2026

Ok i added a switch for that one parameter. Im fine either way, this or the previous version.

usteer-ng is the forked version of usteer with more options and
improvements. This commit allows setting the additional options
in luci-app-usteer.

Next to that a small bug is fixed.

Signed-off-by: Ramon Van Gorkom <Ramon00c00@gmail.com>
@Ramon00 Ramon00 force-pushed the add-usteer-ng-params branch from cf30bda to 7da6435 Compare March 16, 2026 22:10
@Ramon00
Copy link
Contributor Author

Ramon00 commented Mar 16, 2026

optimized a bit

@systemcrash systemcrash merged commit 7a188f5 into openwrt:master Mar 16, 2026
5 checks passed
@systemcrash
Copy link
Contributor

Merged. Thanks @Ramon00

@github-actions

This comment has been minimized.

@Ramon00 Ramon00 deleted the add-usteer-ng-params branch March 17, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants