kernel/mediatek: fix null dereference in dynamic calibration patch#23205
Conversation
| + int datalen = ctlr->cal_rule->datalen; | ||
| + int addrlen = ctlr->cal_rule->addrlen; | ||
| + int datalen; | ||
| + int addrlen; |
There was a problem hiding this comment.
The same null-deref pattern exists in patches-6.18/432-drivers-spi-Add-support-for-dynamic-calibration.patch (int datalen = ctlr->cal_rule->datalen; / int addrlen = ctlr->cal_rule->addrlen; ahead of the if(!ctlr->cal_target || !ctlr->cal_rule || !ctlr->append_caldata) guard at line 30). target/linux/mediatek/Makefile sets KERNEL_PATCHVER:=6.18, so the 6.18 patch is the one actually built on this branch (and on main, where patches-6.12/ no longer exists). Should this PR also patch the 6.18 copy, or is it intentionally limited to 6.12?
Generated by Claude Code
There was a problem hiding this comment.
Looks like Claude is looking at the wrong branch, it's KERNEL_PATCHVER:=6.12 on 25.12. A separate PR will be needed for 6.18 on main.
github-actions
Bot
added
target/mediatek
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
No issues found.
To address review feedback, force-push fixes to this branch. Don't close and open a new PR — that loses the review history and the bot starts from scratch.
Generated by Claude Code
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
To address review feedback, force-push fixes to this branch. Don't close and open a new PR — that loses the review history and the bot starts from scratch.
Generated by Claude Code
|
Please add this to the main branch first, we can then backport it to 25.12. |
|
Rebased to main: #23237 |
662b4c6 to
32b9e94
Compare
pcc
changed the title
KASAN reported a null dereference in this patch. Fix it. Signed-off-by: Peter Collingbourne <peter@pcc.me.uk> Link: openwrt#23237 Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com> (cherry picked from commit 317317d) Link: openwrt#23205 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
KASAN reported a null dereference in this patch. Fix it. Signed-off-by: Peter Collingbourne <peter@pcc.me.uk> Link: openwrt#23237 Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com> (cherry picked from commit 317317d) Link: openwrt#23205 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
KASAN reported a null dereference in this patch. Fix it. Signed-off-by: Peter Collingbourne <peter@pcc.me.uk> Link: openwrt/openwrt#23237 Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com> (cherry picked from commit 317317d960e3edb5891ee4d25c3d654074cb568d) Link: openwrt/openwrt#23205 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit d34a54f4db2af3224576ed1c2c72989426efcdf5)
4 participants
KASAN reported a null dereference in this patch. Fix it.