conmon: update to 2.0.30 by oskarirauta · Pull Request #17063 · openwrt/packages

oskarirauta · 2021-11-04T18:00:17Z

bug fixes:

Remove unreachable code path
exit: report if the exit command was killed
exit: fix race zombie reaper
conn_sock: allow watchdog messages through the notify socket proxy
seccomp: add support for seccomp notify

misc:

Add seccomp to build dependency

included patch removes unnecessary dependency of libdl and also allows a succesfull build

Signed-off-by: Oskari Rauta oskari.rauta@gmail.com

Maintainer: Oskari Rauta / @oskarirauta
Compile tested: x86_64, pc, recent snapshot
Run tested: x86_64, pc, quite recent snapshot

bug fixes: - Remove unreachable code path - exit: report if the exit command was killed - exit: fix race zombie reaper - conn_sock: allow watchdog messages through the notify socket proxy - seccomp: add support for seccomp notify misc: - Add seccomp to build dependency included patch removes unnecessary dependency of libdl and also allows a succesfull build disabled for arc where libseccomp does not seem to be available Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>

PolynomialDivision · 2021-11-05T06:28:04Z

utils/conmon/Makefile

 PKG_LICENSE_FILES:=LICENSE

-PKG_BUILD_DEPENDS:=golang/host
+PKG_BUILD_DEPENDS:=golang/host libseccomp


I'm not familiar with this package. But are you sure you just need that at build and not runtime? For example your package crun has that as dependency:
https://github.com/openwrt/packages/blob/master/utils/crun/Makefile#L29

Yes. Build bot here failed because of missing libseccomp.h, so I had to add it as a build dependency. libseccomp is not available for arc, and that's why arc is disabled. Better would be to take parts of libseccomp that are required and integrate them to common, but that would possibly need building that system every time libseccomp updates- so better this way. libseccomp is not needed on runtime, just something from header file.

PolynomialDivision · 2021-11-05T15:54:15Z

thanks. lgtm

jefferyto · 2021-11-05T20:15:39Z

This is unrelated to this update, but I noticed that this package has a build dependency on golang/host. The CI passed even for platforms that Go doesn’t support (powerpc), so either it’s not compiling correctly for the target platform (instead compiling for the build platform), or no runtime component written in Go is being compiled (only components needed for build-time).

Looking at the upstream PR that added the Go dependency (containers/conmon#41), it appears that the Go component(s) are only used when conman is a dependency of another Go program.

If this is true, you may want to patch out compiling the Go component(s) instead of including the build dependency on golang/host, that may speed up the compilation of this package.

@jefferyto