conmon: remove unnecessary dependency#17204
Merged
neheb merged 1 commit intoopenwrt:masterfrom Nov 29, 2021
Merged
Conversation
Member
Otherwise, this comment: #17063 (comment) was more clear than your commit description, but from my side, it is nitpicking. |
Contributor
Author
I agree. |
Contributor
Author
|
@BKPepe how about approving it then? |
oskarirauta
changed the title
this patch removes unnecessary dependency to golang/host as pointed out by @jefferyto earlier at openwrt#17063 (comment) Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
Member
|
Apologies for not reviewing this PR in time. @oskarirauta In the future, I suggest adding the actual comment link ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch removes unnecessary dependency to golang/host
as pointed out by @jefferyto earlier at #17063
Signed-off-by: Oskari Rauta oskari.rauta@gmail.com
Maintainer: Oskari Rauta / @oskarirauta
Compile tested: x86_64, git
Run tested: x86_64, git