fluent-bit: update to 5.0.8, adopt maintainer, fix musl startup segfault#29914
Conversation
|
So... it fixes #29777 this one, right? |
yes; |
|
Can we do something about this one? fluent-bit: [warn] Binary /usr/sbin/fluent-bit contains a hardcoded build path |
| -DWITH_ZLIB=No \ | ||
| -DWITH_ZSTD=No | ||
| -DWITH_ZSTD=No \ | ||
| -DFLB_HAVE_C_TLS:BOOL=On |
There was a problem hiding this comment.
Is this what's causing the segfault or is it -DFLB_CORO_STACK_SIZE=4096?
There was a problem hiding this comment.
short answer: yes;
the crash is in pthread_getspecific() https://github.com/fluent/fluent-bit/blob/v5.0.8/include/fluent-bit/flb_thread_storage.h#L32-L69
when FLB_HAVE_C_TLS is undefined, then #define FLB_TLS_GET(key) pthread_getspecific(key)
the implementation differs from glibc to musl
glibc:
https://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/pthread_getspecific.c;hb=HEAD
musl:
https://git.musl-libc.org/cgit/musl/tree/src/thread/pthread_getspecific.c
basically, for musl, we need to enforce thread-local-storage, otherwise pthread_getspecific() crashes, because it calls pthread_key_create() before pthread_getspecific().
glibc's pthread_getspecific() doesn't crash
this may be fixable also upstream in fluent-bit;
i'll report it
There was a problem hiding this comment.
We can patch it. |
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; commit message matches the diff. Version bump to 5.0.8 (upstream tag confirmed) with PKG_RELEASE correctly reset to 1, maintainer adoption, and a well-documented musl TLS fix. One minor style nit inline.
Generated by Claude Code
| -DWITH_ZLIB=No \ | ||
| -DWITH_ZSTD=No | ||
| -DWITH_ZSTD=No \ | ||
| -DFLB_HAVE_C_TLS:BOOL=On |
There was a problem hiding this comment.
nit: every other option in this CMAKE_OPTIONS block uses the bare =Yes/=No form (e.g. -DFLB_RELEASE=Yes, -DWITH_ZSTD=No). This one adds a :BOOL=On type annotation, which is functionally equivalent but stylistically inconsistent with the rest of the file.
| -DFLB_HAVE_C_TLS:BOOL=On | |
| -DFLB_HAVE_C_TLS=Yes |
Generated by Claude Code
Update 4.2.0 -> 5.0.8 and adopt maintainership. fluent-bit segfaulted at startup on every musl target: under GCC 14 the upstream C-TLS probe no longer compiles (undeclared __tls_get_addr), so the pthread_key fallback calls pthread_getspecific() before pthread_key_create() and derefs a NULL tsd array on musl (glibc is unaffected). Force -DFLB_HAVE_C_TLS=Yes for __thread TLS. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
|
4 participants
📦 Package Details
Maintainer: me
Description:
Update 4.2.0 -> 5.0.8 and adopt maintainership. fluent-bit segfaulted at
startup on every musl target: under GCC 14 the upstream C-TLS probe no longer
compiles (undeclared __tls_get_addr), so the pthread_key fallback calls
pthread_getspecific() before pthread_key_create() and derefs a NULL tsd array
on musl (glibc is unaffected). Force -DFLB_HAVE_C_TLS:BOOL=On for __thread TLS.
Fixes #29777
🧪 Run Testing Details
✅ Formalities