Skip to content

snapcast: add libsoxr dependency to snapclient (as was done already for snapserver)#30079

Merged
mirko merged 1 commit into
openwrt:masterfrom
mirko:snapcast-fix-snapclient-build
Jul 22, 2026
Merged

snapcast: add libsoxr dependency to snapclient (as was done already for snapserver)#30079
mirko merged 1 commit into
openwrt:masterfrom
mirko:snapcast-fix-snapclient-build

Conversation

@mirko

@mirko mirko commented Jul 22, 2026

Copy link
Copy Markdown
Member

snapcast: add libsoxr dependency to snapclient

SNAPCAST_SOXR passes -DBUILD_WITH_SOXR, which is a build-wide CMake
option: snapserver and snapclient are built from one source tree and
both link libsoxr. The dependency was declared only on snapserver, so
with SNAPCAST_SOXR enabled (the default) the snapclient package failed
at the packaging step:

Package snapclient is missing dependencies for the following libraries:
libsoxr.so.0

Declare +SNAPCAST_SOXR:libsoxr on snapclient too, and relabel the option
"(server + client)" so its build-wide scope is clear.

📦 Package Details

Maintainer: @xabolcs @davidandreoletti
Szabolcs Hubai szab.hu@gmail.com, David Andreoletti david@andreoletti.net

Description:
see above


🧪 Run Testing Details

  • OpenWrt Version: master (305c7599e5fa400cf6221fd0a596dbd014529235)
  • OpenWrt Target/Subtarget: x86_64
  • OpenWrt Device: qemu/kvm

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

SNAPCAST_SOXR passes -DBUILD_WITH_SOXR, which is a build-wide CMake
option: snapserver and snapclient are built from one source tree and
both link libsoxr. The dependency was declared only on snapserver, so
with SNAPCAST_SOXR enabled (the default) the snapclient package failed
at the packaging step:

  Package snapclient is missing dependencies for the following libraries:
  libsoxr.so.0

Declare +SNAPCAST_SOXR:libsoxr on snapclient too, and relabel the option
"(server + client)" so its build-wide scope is clear.

Fixes: 7673cd9 ("snapcast: make build options explicit and per-package deps precise")
Signed-off-by: Mirko Vogt <mirko-openwrt@nanl.de>
@openwrt

openwrt Bot commented Jul 22, 2026

Copy link
Copy Markdown

Formality Check: Suggestions Available

We completed the verification flow. Please review the formatting overview logs below.

⚠️ STYLISTIC WARNINGS & SUGGESTIONS

Package Release Audit:

  • ⚠️ Package sound/snapcast content changed without a PKG_RELEASE or version bump. Please increment PKG_RELEASE by 1 (or bump PKG_VERSION/PKG_SOURCE_DATE and reset PKG_RELEASE to 1) so users receive the update.
  • Do not increment release for minor changes. Cosmetic edits (e.g., typos in comments, copyright updates, formatting/whitespace), changing the package maintainer (PKG_MAINTAINER), or updating source download info (PKG_SOURCE_URL / PKG_HASH) do not require incrementing PKG_RELEASE.

Something broken? Consider reporting an issue.
Running version f3161d5 deployed on 2026-07-22 02:15:51 CEST

@xabolcs

xabolcs commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
Package snapclient is missing dependencies for the following libraries:
libsoxr.so.0

Please wait for successful package build!

@mirko

mirko commented Jul 22, 2026

Copy link
Copy Markdown
Member Author
Package snapclient is missing dependencies for the following libraries:
libsoxr.so.0

Please wait for successful package build!

Not sure I understand. This PR is fixing an issue - this very specific one actually - I introduced with the previous commit.

I don't see the need for bumping PKG_RELEASE here, but if it makes everyone happy, I can do that, too, of course (it doesn't change anything for snapserver, and snapclient couldn't build with SOXR enabled, so for builds which succeeded, nothing changes).

@xabolcs

xabolcs commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Not sure I understand. This PR is fixing an issue - this very specific one actually - I introduced with the previous commit.

Yup! And I don't see / understand how that could happened with compile testing. 😕
So I hope if we got installable packages from action run, then we won't need more fix commits.

I'm hoping this because the last PR weren't compile tested by GH Actions: it was merget before it.

But sure, this is already a fixing commit, so if you are in a hurry, then land it! 👌

@mirko

mirko commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

Not sure I understand. This PR is fixing an issue - this very specific one actually - I introduced with the previous commit.

Yup! And I don't see / understand how that could happened with compile testing. 😕 So I hope if we got installable packages from action run, then we won't need more fix commits.

I'm hoping this because the last PR weren't compile tested by GH Actions: it was merget before it.

But sure, this is already a fixing commit, so if you are in a hurry, then land it! 👌

I'm not in a hurry, just figured landing it ASAP would save users potential trouble as well as automatic build resources.
Will merge on your "go" - and/but don't mind waiting. Will happily follow the/your process.

@xabolcs

xabolcs commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

just figured landing it ASAP would save users potential trouble as well as automatic build resources.

ACK!
Approved, please land! 🙏

Will happily follow the/your process.

Thanks. Let's wait for those workers on the next feature PR but not for "hotfixing" PRs!

@mirko
mirko merged commit 084f892 into openwrt:master Jul 22, 2026
4 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants