Skip to content

mdio-tools: disable mold linker - #30153

Open
testuser7 wants to merge 1 commit into
openwrt:masterfrom
testuser7:mdio
Open

mdio-tools: disable mold linker#30153
testuser7 wants to merge 1 commit into
openwrt:masterfrom
testuser7:mdio

Conversation

@testuser7

@testuser7 testuser7 commented Aug 4, 2026

Copy link
Copy Markdown

📦 Package Details

Maintainer: @dmascord
(You can find this by checking the history of the package Makefile.)

Description:

The mold linker is not supported by mdio-tools.
Disabling mold linker allows the package to be built on systems with a configured mold linker.

Fixes: #30101


🧪 Run Testing Details

  • OpenWrt Version: snapshot
  • OpenWrt Target/Subtarget: mediatek/filogic
  • OpenWrt Device: -

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@openwrt

openwrt Bot commented Aug 4, 2026

Copy link
Copy Markdown

Formality Check: Suggestions Available

We checked this pull request against the contribution guidelines. Here is what needs your attention:

⚠️ STYLISTIC WARNINGS & SUGGESTIONS

Package Release Audit:

  • ⚠️ Content changed in these packages, but without a PKG_RELEASE or version bump:

    • net/mdio-tools

    Increment PKG_RELEASE by 1 (or bump PKG_VERSION/PKG_SOURCE_DATE and reset PKG_RELEASE to 1) so users receive the update.

Do not increment release for minor changes. Cosmetic edits (e.g., typos in comments, copyright updates, formatting/whitespace), changing the package maintainer (PKG_MAINTAINER), or updating source download info (PKG_SOURCE_URL / PKG_HASH) do not require incrementing PKG_RELEASE.


Something broken? Consider reporting an issue.
Running version 9016fac deployed on 2026-08-05 05:43:29 CEST

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit. One inline finding: the mold opt-out should use the supported PKG_BUILD_FLAGS:=no-mold mechanism rather than appending a second -fuse-ld= to TARGET_LDFLAGS. Nothing else blocking; the PKG_RELEASE point is already covered by the formality bot.


Generated by Claude Code

Comment thread net/mdio-tools/Makefile Outdated
The mold linker is not supported by mdio-tools.
Disabling mold linker allows the package to be built
on systems with a configured mold linker.

Fixes: openwrt#30101
Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
@testuser7 testuser7 changed the title mdio-tools: force ld linker usage mdio-tools: disable mold linker Aug 5, 2026

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.

The force-push replaces TARGET_LDFLAGS += -fuse-ld=bfd with PKG_BUILD_FLAGS:=no-mold, which resolves the earlier finding: no-mold is an accepted value in include/package.mk:28 and gates TARGET_LINKER:=mold at include/package.mk:59-63, so TARGET_LINKER correctly falls back to the bfd default from rules.mk:253-254 instead of ending up with two conflicting -fuse-ld= flags. The assignment is placed before include $(INCLUDE_DIR)/package.mk, as required, and the commit subject now matches what the diff does.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mdio-tools: no support for mold linker

2 participants