mdio-tools: disable mold linker - #30153
Conversation
Formality Check: Suggestions AvailableWe checked this pull request against the contribution guidelines. Here is what needs your attention:
|
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. One inline finding: the mold opt-out should use the supported PKG_BUILD_FLAGS:=no-mold mechanism rather than appending a second -fuse-ld= to TARGET_LDFLAGS. Nothing else blocking; the PKG_RELEASE point is already covered by the formality bot.
Generated by Claude Code
The mold linker is not supported by mdio-tools. Disabling mold linker allows the package to be built on systems with a configured mold linker. Fixes: openwrt#30101 Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
The force-push replaces TARGET_LDFLAGS += -fuse-ld=bfd with PKG_BUILD_FLAGS:=no-mold, which resolves the earlier finding: no-mold is an accepted value in include/package.mk:28 and gates TARGET_LINKER:=mold at include/package.mk:59-63, so TARGET_LINKER correctly falls back to the bfd default from rules.mk:253-254 instead of ending up with two conflicting -fuse-ld= flags. The assignment is placed before include $(INCLUDE_DIR)/package.mk, as required, and the commit subject now matches what the diff does.
Generated by Claude Code
📦 Package Details
Maintainer: @dmascord
(You can find this by checking the history of the package
Makefile.)Description:
The mold linker is not supported by mdio-tools.
Disabling mold linker allows the package to be built on systems with a configured mold linker.
Fixes: #30101
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.