miniupnpd: Update to 2.1.20190408#8671
Merged
Merged
Conversation
Contributor
Author
|
Cleaned up the Makefile slightly. |
Contributor
Author
|
Huh, locally $(FPIC) is not needed. This requires further investigation. |
neheb
force-pushed
the
mini
branch
2 times, most recently
from
b7e5e68 to
19d968a
Compare
Refreshed patch. Added PKG_LICENSE_FILES. Added --as-needed linker flag for slightly smaller size. Removed -O2 hack to get it to compile. As part of this, removed a bunch of CFLAGS that are normally passed which potentially affect compilation with Os. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Contributor
|
Are you sure that it works fine without -O2? Also keep the CFLAGS from upstream that doesn't conflict with toolchain |
Contributor
Author
|
Yep. Working fine here. The reason I commented out those entries is because those -f entries might be causing bad compilation. Will investigate an easier way to do this. |
Contributor
Author
|
Merging. A user is waiting on this. FWIW I have 5 days uptime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshed patch.
Added --as-needed linker flag for smaller size.
Signed-off-by: Rosen Penev rosenp@gmail.com
Maintainer: nobody
Compile tested: ath79
Run tested: Archer C7 v2