Netopeer2 Bundle#9491
Conversation
neheb
force-pushed
the
bundle
branch
2 times, most recently
from
96de2f2 to
ca118f4
Compare
Cleaned up Makefile slightly. The removed CMAKE_OPTIONS are defaults from cmake.mk Removed Upstreamed patches. Rebased and added .patch to the remaining one. Added -Wformat-security patch. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Makefile cleanups for consistency between packages. Placed libsysrepo in Libraries instead of Utilities. Removed InstallDev as it is implied by CMAKE_INSTALL. Added .patch at the end of patch files. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Small cleanups. Removed upstreamed patch. Suffixed all patches with .patch Signed-off-by: Rosen Penev <rosenp@gmail.com>
Python 2 will be EOL by the end of the year. Switch to Python 3 as there is already support for it. Signed-off-by: Rosen Penev <rosenp@gmail.com>
| $(INSTALL_DATA) $(PKG_BUILD_DIR)/swig/python2/libsysrepoPython2.py $(1)$(PYTHON_PKG_DIR) | ||
| $(INSTALL_DATA) $(PKG_BUILD_DIR)/swig/python2/_libsysrepoPython2.so $(1)$(PYTHON_PKG_DIR) | ||
| $(INSTALL_DATA) $(PKG_BUILD_DIR)/swig/python3/libsysrepoPython3.py $(1)$(PYTHON_PKG_DIR) | ||
| $(INSTALL_DATA) $(PKG_BUILD_DIR)/swig/python3/_libsysrepoPython3.so $(1)$(PYTHON_PKG_DIR) |
There was a problem hiding this comment.
Should these references to PYTHON_PKG_DIR be for PYTHON3_PKG_DIR instead?
There was a problem hiding this comment.
Also, are there packages that depend on these Python bindings? Do they need Python 2 bindings or can they work with Python 3?
I'm wondering if we should (and if it is possible to) offer both Python 2 and 3 bindings, keeping the Python 2 bindings around until the mass removal in 2020.
There was a problem hiding this comment.
I don’t think anything uses these. Feel free to open a PR fixing up some of the loose ends.
There was a problem hiding this comment.
See #10554 - I decided against building Python 2 bindings because it would have been difficult to build both Python 2 and 3 bindings (but not totally impossible), but also as you said, nothing here uses it.
In fact, if you wanted these bindings before, you had to manually build the package with the config option set. If someone really needs Python 2 bindings, they can edit the Makefiles and build it themselves.
2 participants
Maintainer: @mislavn
Compile tested: ath79
This is a bundle needed to get Netopeer2 to the latest version.
Several fixes went into this, including some compile fixes for newer GCC.