Skip to content

libupnpp and upmpdcli#9687

Merged
neheb merged 2 commits into
openwrt:masterfrom
neheb:libup
Aug 14, 2019
Merged

libupnpp and upmpdcli#9687
neheb merged 2 commits into
openwrt:masterfrom
neheb:libup

Conversation

@neheb

@neheb neheb commented Aug 10, 2019

Copy link
Copy Markdown
Contributor

Maintainer: @ignisf

@ignisf

ignisf commented Aug 12, 2019

Copy link
Copy Markdown
Contributor

Hello, thank you for the PR. While there, would you be willing to bump the Python dependency to point to Python 3?

@diizzyy

diizzyy commented Aug 12, 2019

Copy link
Copy Markdown
Contributor

Needs a run-time test before merging.

@neheb

neheb commented Aug 12, 2019

Copy link
Copy Markdown
Contributor Author

Where's the Python dependency?

@ignisf

ignisf commented Aug 13, 2019

Copy link
Copy Markdown
Contributor

@neheb

neheb commented Aug 13, 2019

Copy link
Copy Markdown
Contributor Author

Done

@ignisf

ignisf commented Aug 13, 2019

Copy link
Copy Markdown
Contributor

lgtm thanks

neheb added 2 commits August 14, 2019 00:52
Fixed up license information.

Added PKG_BUILD_PARALLEL for faster compilation.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Fixed license information.

Added PKG_BUILD_PARALLEL for faster compilation.

Removed upstreamed patch.

Ran init script through shellcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb neheb merged commit a454b4b into openwrt:master Aug 14, 2019
@neheb neheb deleted the libup branch September 3, 2019 19:32
@jefferyto

Copy link
Copy Markdown
Member

The Python dependency is unchanged?

select PACKAGE_python

@neheb

neheb commented Nov 4, 2019

Copy link
Copy Markdown
Contributor Author

Fixed.

@jefferyto

Copy link
Copy Markdown
Member

Thanks! (The change is fa005f4.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants