Consider equal and comma are safe in URLs for proper Youtube JS player operation#317
Merged
Conversation
benoit74
force-pushed
the
youtube_url_rewriting
branch
from
July 23, 2026 14:51
a0e1697 to
1c05e5e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
===========================================
- Coverage 100.00% 99.96% -0.04%
===========================================
Files 41 41
Lines 2555 2554 -1
Branches 365 364 -1
===========================================
- Hits 2555 2553 -2
- Misses 0 1 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
benoit74
force-pushed
the
youtube_url_rewriting
branch
from
July 23, 2026 15:07
1c05e5e to
c795611
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #316
Changes:
,and=are safe to use in URLs (e.g. found in HTML document) so that Youtube JS player works fineNota: I did not extended the list to other characters since for now this seems to be sufficient and we might experience negative side-effects