Skip to content

Consider equal and comma are safe in URLs for proper Youtube JS player operation#317

Merged
benoit74 merged 1 commit into
mainfrom
youtube_url_rewriting
Jul 23, 2026
Merged

Consider equal and comma are safe in URLs for proper Youtube JS player operation#317
benoit74 merged 1 commit into
mainfrom
youtube_url_rewriting

Conversation

@benoit74

Copy link
Copy Markdown
Collaborator

Fix #316

Changes:

  • consider , and = are safe to use in URLs (e.g. found in HTML document) so that Youtube JS player works fine

Nota: I did not extended the list to other characters since for now this seems to be sufficient and we might experience negative side-effects

@benoit74 benoit74 self-assigned this Jul 23, 2026
@benoit74
benoit74 force-pushed the youtube_url_rewriting branch from a0e1697 to 1c05e5e Compare July 23, 2026 14:51
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (295fefc) to head (c795611).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #317      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files           41       41              
  Lines         2555     2554       -1     
  Branches       365      364       -1     
===========================================
- Hits          2555     2553       -2     
- Misses           0        1       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74
benoit74 force-pushed the youtube_url_rewriting branch from 1c05e5e to c795611 Compare July 23, 2026 15:07
@benoit74
benoit74 merged commit 1a652a5 into main Jul 23, 2026
8 checks passed
@benoit74
benoit74 deleted the youtube_url_rewriting branch July 23, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URL rewriting: Youtube JS player fails when we URL-encode = and , characters

1 participant