fix(bridge): match headed mode on bridge discover - #35
Merged
Conversation
mateuszk-opera
force-pushed
the
wp/fix-for-headed-mode-respawning-bridge
branch
from
September 1, 2026 12:19
2a9151c to
771dd22
Compare
macieju-opera
approved these changes
Sep 1, 2026
macieju-opera
left a comment
macieju-opera
left a comment
Contributor
There was a problem hiding this comment.
LGTM. This is a clean fix for a real bug — headed/headless mode mismatch causing bridge reuse where it shouldn't.
- Adding
headedtoBridgeHealthis the right place — it's an identity property that affects bridge selection - Defaulting to
falseinparseHealthfor pre-0.2.7 bridges is safe: old bridges didn't report the field, and mismatching on the safe side (restart) is better than reusing a bridge in the wrong mode - The dual-pass probe loop (find usable → clean up ours) correctly handles the case where a bridge exists but in the wrong mode — it gets shut down in the cleanup pass
No issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.