feat: Add company billing page with subscription state overview#4541
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
BillingStatusBadge, theclassNamelookup assumes theBillingStatusunion will never grow; consider adding a default/fallback style so new or unexpected statuses don’t render with missing styling. - The
Current plansection shows the billing interval both under the plan heading and again in the detail rows; you may want to remove one of these to avoid redundant information. - A new
paths.test.tsfile is introduced but has no contents in this diff; if it’s not needed yet, consider removing it or populating it to avoid having a dead/placeholder test file in the tree.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `BillingStatusBadge`, the `className` lookup assumes the `BillingStatus` union will never grow; consider adding a default/fallback style so new or unexpected statuses don’t render with missing styling.
- The `Current plan` section shows the billing interval both under the plan heading and again in the detail rows; you may want to remove one of these to avoid redundant information.
- A new `paths.test.ts` file is introduced but has no contents in this diff; if it’s not needed yet, consider removing it or populating it to avoid having a dead/placeholder test file in the tree.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.