fix: notify goal description mentions

[mancinux]

resolves #1219

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• In GoalCreated.dispatch/1, consider guarding against goal.description being nil (e.g., by defaulting to an empty rich text structure) before calling RichContent.find_mentioned_ids/2 to avoid edge-case crashes when a goal is created without a description.
• For load_preloaded_resource(:goal, ids), you may want to normalize g.description (e.g., ensure it is non-nil or in a consistent rich-text shape) so the direct mention classifier doesn't have to handle nil or unexpected formats differently per resource type.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `GoalCreated.dispatch/1`, consider guarding against `goal.description` being `nil` (e.g., by defaulting to an empty rich text structure) before calling `RichContent.find_mentioned_ids/2` to avoid edge-case crashes when a goal is created without a description.
- For `load_preloaded_resource(:goal, ids)`, you may want to normalize `g.description` (e.g., ensure it is non-nil or in a consistent rich-text shape) so the direct mention classifier doesn't have to handle `nil` or unexpected formats differently per resource type.

## Individual Comments

### Comment 1
<location path="app/lib/operately/activities/notifications/goal_created.ex" line_range="8" />
<code_context>
     goal = Operately.Goals.get_goal!(goal_id)

-    people = [goal.champion_id, goal.reviewer_id]
+    mentioned_ids = RichContent.find_mentioned_ids(goal.description, :decode_ids)
+    people = [goal.champion_id, goal.reviewer_id | mentioned_ids]

</code_context>
<issue_to_address>
**issue (bug_risk):** Guard against nil goal.description when passing it into RichContent.find_mentioned_ids.

If `goal.description` can be `nil` (e.g. for API-created or legacy goals), this call can raise. Please normalize to a safe default (e.g. `goal.description || ""` or a guard clause) before calling `RichContent.find_mentioned_ids/2`.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}