fix: open milestone tasks in slide-in#4592
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="app/assets/js/pages/MilestonePage/index.tsx" line_range="233-242" />
<code_context>
+ [milestone.id, projectId, updateTaskMilestone],
+ );
+
+ const handleTaskDelete = React.useCallback(
+ async (taskId: string) => {
+ const result = await deleteTask(taskId);
+
+ if (!result?.success) return;
+
+ if (milestone.project?.id) {
+ PageCache.invalidate(projectPageCacheKey(milestone.project.id));
+ }
+ },
+ [deleteTask, milestone.project?.id],
+ );
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Task delete handler should also invalidate the milestone page/kanban caches
In `handleTaskDelete`, only `projectPageCacheKey(milestone.project.id)` is invalidated. Because the milestone page and kanban views also show this task, you should also invalidate `pageCacheKey(milestone.id)` and `milestoneKanbanPageCacheKey(milestone.id)` to avoid stale UIs and keep behavior consistent with the move/milestone-change flows.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mancinux
force-pushed
the
press-return-on-milestone
branch
from
May 31, 2026 23:27
48ced03 to
3b03e0e
Compare
Signed-off-by: Luca Mancini <lmancini@operately.com>
mancinux
force-pushed
the
press-return-on-milestone
branch
from
May 31, 2026 23:51
3b03e0e to
4b9388b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4570