chore: Improve CI speed#4633
Merged
Merged
Conversation
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In scripts/run_ee_tests.js, the new usages of fs (existsSync, rmSync, renameSync) and path.join require adding corresponding
require("fs")andrequire("path")statements at the top of the file to avoid runtime reference errors. - In scripts/test_file_splitter.js, the validation
if (index >= total)conflicts with the error message "SPLIT_INDEX must be less than or equal to SPLIT_TOTAL"; either change the condition toindex > totalor adjust the message to reflect the actual constraint.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In scripts/run_ee_tests.js, the new usages of fs (existsSync, rmSync, renameSync) and path.join require adding corresponding `require("fs")` and `require("path")` statements at the top of the file to avoid runtime reference errors.
- In scripts/test_file_splitter.js, the validation `if (index >= total)` conflicts with the error message "SPLIT_INDEX must be less than or equal to SPLIT_TOTAL"; either change the condition to `index > total` or adjust the message to reflect the actual constraint.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Rockyy174
force-pushed
the
split-unit-tests
branch
from
June 5, 2026 16:01
1d641de to
82db77a
Compare
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.