Skip to content

chore: Improve CI speed#4633

Merged
Rockyy174 merged 14 commits into
operately:mainfrom
Rockyy174:split-unit-tests
Jun 5, 2026
Merged

chore: Improve CI speed#4633
Rockyy174 merged 14 commits into
operately:mainfrom
Rockyy174:split-unit-tests

Conversation

@Rockyy174

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In scripts/run_ee_tests.js, the new usages of fs (existsSync, rmSync, renameSync) and path.join require adding corresponding require("fs") and require("path") statements at the top of the file to avoid runtime reference errors.
  • In scripts/test_file_splitter.js, the validation if (index >= total) conflicts with the error message "SPLIT_INDEX must be less than or equal to SPLIT_TOTAL"; either change the condition to index > total or adjust the message to reflect the actual constraint.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In scripts/run_ee_tests.js, the new usages of fs (existsSync, rmSync, renameSync) and path.join require adding corresponding `require("fs")` and `require("path")` statements at the top of the file to avoid runtime reference errors.
- In scripts/test_file_splitter.js, the validation `if (index >= total)` conflicts with the error message "SPLIT_INDEX must be less than or equal to SPLIT_TOTAL"; either change the condition to `index > total` or adjust the message to reflect the actual constraint.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Rockyy174 added 7 commits June 4, 2026 15:10
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
@Rockyy174
Rockyy174 requested a review from shiroyasha June 5, 2026 00:34
@Rockyy174 Rockyy174 changed the title chore: Split unit tests in Semaphore CI chore: Improve CI speed Jun 5, 2026
Rockyy174 added 4 commits June 4, 2026 21:52
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Rockyy174 added 2 commits June 5, 2026 13:02
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
@Rockyy174
Rockyy174 merged commit 846b713 into operately:main Jun 5, 2026
3 checks passed
@Rockyy174
Rockyy174 deleted the split-unit-tests branch June 5, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant