chore: Demo includes documents and links for projects and goals#4704
Merged
Conversation
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
link_content/2, the fallback clause callsPoorMansMarkdown.from_markdown("", %{}), which is inconsistent with the other uses (passingresources) and loses access to the resource context; consider either passingresourcesthere as well or returningnil/""directly if no content is provided. - The new
get_hub/2clauses pattern match on%{project: ...},%{goal: ...}, and%{space: ...}only; it may be safer to either guard against or explicitly handle the case where none of these keys are present to avoid aFunctionClauseErrorfrom malformed demo data.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `link_content/2`, the fallback clause calls `PoorMansMarkdown.from_markdown("", %{})`, which is inconsistent with the other uses (passing `resources`) and loses access to the resource context; consider either passing `resources` there as well or returning `nil`/`""` directly if no content is provided.
- The new `get_hub/2` clauses pattern match on `%{project: ...}`, `%{goal: ...}`, and `%{space: ...}` only; it may be safer to either guard against or explicitly handle the case where none of these keys are present to avoid a `FunctionClauseError` from malformed demo data.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.