Skip to content

chore: Demo includes documents and links for projects and goals#4704

Merged
Rockyy174 merged 1 commit into
operately:mainfrom
Rockyy174:expand-demo
Jun 22, 2026
Merged

chore: Demo includes documents and links for projects and goals#4704
Rockyy174 merged 1 commit into
operately:mainfrom
Rockyy174:expand-demo

Conversation

@Rockyy174

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In link_content/2, the fallback clause calls PoorMansMarkdown.from_markdown("", %{}), which is inconsistent with the other uses (passing resources) and loses access to the resource context; consider either passing resources there as well or returning nil/"" directly if no content is provided.
  • The new get_hub/2 clauses pattern match on %{project: ...}, %{goal: ...}, and %{space: ...} only; it may be safer to either guard against or explicitly handle the case where none of these keys are present to avoid a FunctionClauseError from malformed demo data.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `link_content/2`, the fallback clause calls `PoorMansMarkdown.from_markdown("", %{})`, which is inconsistent with the other uses (passing `resources`) and loses access to the resource context; consider either passing `resources` there as well or returning `nil`/`""` directly if no content is provided.
- The new `get_hub/2` clauses pattern match on `%{project: ...}`, `%{goal: ...}`, and `%{space: ...}` only; it may be safer to either guard against or explicitly handle the case where none of these keys are present to avoid a `FunctionClauseError` from malformed demo data.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Rockyy174
Rockyy174 merged commit 76e5dca into operately:main Jun 22, 2026
3 checks passed
@Rockyy174
Rockyy174 deleted the expand-demo branch June 22, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant