Skip to content

fix: Project page cache is cleared on pausing and resuming#4799

Merged
Rockyy174 merged 2 commits into
mainfrom
fix-project-cache
Jul 9, 2026
Merged

fix: Project page cache is cleared on pausing and resuming#4799
Rockyy174 merged 2 commits into
mainfrom
fix-project-cache

Conversation

@Rockyy174

Copy link
Copy Markdown
Collaborator

No description provided.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In wait_until_project/4, the description string is used only in the timeout error; consider including the last fetched project state or key fields in the error to aid debugging when these waits fail in CI.
  • The resume flow waits for project.status != "paused"; if there are multiple possible non-paused states, it may be safer to wait for the explicit expected status (e.g. "active") to avoid masking unexpected state transitions.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `wait_until_project/4`, the `description` string is used only in the timeout error; consider including the last fetched project state or key fields in the error to aid debugging when these waits fail in CI.
- The resume flow waits for `project.status != "paused"`; if there are multiple possible non-paused states, it may be safer to wait for the explicit expected status (e.g. `"active"`) to avoid masking unexpected state transitions.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Rockyy174 added 2 commits July 9, 2026 13:18
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
@Rockyy174
Rockyy174 merged commit 9cf8630 into main Jul 9, 2026
4 checks passed
@Rockyy174
Rockyy174 deleted the fix-project-cache branch July 9, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant