Skip to content

feat: Show accurate posting times in check-in headers#4833

Merged
Rockyy174 merged 1 commit into
mainfrom
check-in-timestamp
Jul 15, 2026
Merged

feat: Show accurate posting times in check-in headers#4833
Rockyy174 merged 1 commit into
mainfrom
check-in-timestamp

Conversation

@Rockyy174

Copy link
Copy Markdown
Collaborator

Fixes #2522.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider tightening the CheckInTimestamp type (e.g., preferring Date at the boundaries) or validating at the call sites, since parseCheckInTimestamp currently throws on invalid strings and this could surface as runtime errors if any caller passes an unexpected value.
  • The conditional styling in CheckInMetadata based on resourceType is starting to get a bit complex; splitting goal and project variants into small wrappers or using a style map could make the layout differences easier to follow and maintain.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider tightening the `CheckInTimestamp` type (e.g., preferring `Date` at the boundaries) or validating at the call sites, since `parseCheckInTimestamp` currently throws on invalid strings and this could surface as runtime errors if any caller passes an unexpected value.
- The conditional styling in `CheckInMetadata` based on `resourceType` is starting to get a bit complex; splitting goal and project variants into small wrappers or using a style map could make the layout differences easier to follow and maintain.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Rockyy174
Rockyy174 merged commit ed5bb75 into main Jul 15, 2026
4 checks passed
@Rockyy174
Rockyy174 deleted the check-in-timestamp branch July 15, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check-in pages should make timestamp of posting available

1 participant