Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

add Zalando Postgres Operator v1.4.0 - #1281

Closed
FxKu wants to merge 1 commit into
operator-framework:masterfrom
FxKu:zalando/postgres-operator
Closed

add Zalando Postgres Operator v1.4.0#1281
FxKu wants to merge 1 commit into
operator-framework:masterfrom
FxKu:zalando/postgres-operator

Conversation

@FxKu

@FxKu FxKu commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: Felix Kunde felix-kunde@gmx.de

Updates to existing Operators

  • Is your new CSV pointing to the previous version with the replaces property?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Submit operators to both upstream-community-operators and community-operators at once
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

@openshift-ci-robot openshift-ci-robot added kubernetes-operator An Operator targeting OperatorHub.io size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 26, 2020
Signed-off-by: Felix Kunde <felix-kunde@gmx.de>
@FxKu
FxKu force-pushed the zalando/postgres-operator branch from b59bf6a to ea46b53 Compare February 26, 2020 16:19
@FxKu

FxKu commented Feb 27, 2020

Copy link
Copy Markdown
Contributor Author

Currently failing with:

	Writing into CRs has an effect      fail
	Labels: 
		"necessity":"required"
		"suite":"basic"
		"test":"writingintocrshaseffecttest"
	Suggestions: 
		The operator should write into objects to update state. No PUT or POST requests from the operator were recorded by the scorecard.
FATAL ERROR
Test operator with scorecard                      [  FAILED  ]

Never seen that here before...

@J0zi J0zi self-assigned this Feb 27, 2020
@J0zi

J0zi commented Feb 27, 2020

Copy link
Copy Markdown
Collaborator

Hi @FxKu, please have a look:
The operator should write into objects to update state. No PUT or POST requests from the operator were recorded by the scorecard.

@FxKu

FxKu commented Feb 27, 2020

Copy link
Copy Markdown
Contributor Author

Well, I've read that 😃
Is this a new requirement? Because we did not change the operator's behavior in that sense and previous PRs passed.

@J0zi

J0zi commented Feb 28, 2020

Copy link
Copy Markdown
Collaborator

Hi @FxKu, more strict rules were applied over time:) Please add it.

@FxKu

FxKu commented Mar 4, 2020

Copy link
Copy Markdown
Contributor Author

Ok, I think this PR can be closed then, because 1.4.0 is already out and does only patching of CRs. We can consider using PUT/POST for future releases. Until then, users of OLM have to live with the 1.3.0 version.

@J0zi

J0zi commented Mar 5, 2020

Copy link
Copy Markdown
Collaborator

Closing per contributor's request.

@Jan-M

Jan-M commented Sep 10, 2020

Copy link
Copy Markdown

@J0zi where can i quickly find information on what and how the score card is checkd? I looked already in the operator sdk but could not immediately find some written documentation?

@cbandy

cbandy commented Sep 16, 2020

Copy link
Copy Markdown
Contributor

@Jan-M when I encountered this error, it was because the tests expected to be able to intercept all API calls by setting the KUBECONFIG environment variable inside the operator deployment.

The scorecard tests were disabled at some point, so it's possible this is no longer an issue here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kubernetes-operator An Operator targeting OperatorHub.io size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants