fix: exclude samples from Maven Central publishing - #3537
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The added skipPublishing property is not consumed by the current release/publishing configuration in this repo, so the module may still be included in the Central publishing bundle.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR aims to prevent Maven Central publishing failures by excluding the Kotlin sample operator module from release publishing, since it doesn’t produce a Javadoc JAR and Central rejects the deployment.
Changes:
- Adds a
skipPublishingproperty tosample-operators/kotlin-operatorintended to prevent publishing of that module.
File summaries
| File | Description |
|---|---|
| sample-operators/kotlin-operator/pom.xml | Adds a property intended to skip publishing this module to avoid Central deployment rejection. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
The module has no Java sources, so maven-javadoc-plugin attaches no javadoc jar to it and Central rejects the whole deployment with "Javadocs must be provided but not found in entries", which is what broke the 5.5.1 release. It only exists as a Kotlin interop E2E test, so keep it out of the published bundle.
47f1844 to
c90a1e3
Compare
Replaces the skipPublishing property on the Kotlin sample with an excludeArtifacts list on central-publishing-maven-plugin, so the exclusion lives next to the publishing configuration, and extends it to every sample module: they are demos and end-to-end tests, not artifacts to depend on.
csviri
changed the title
There was a problem hiding this comment.
🟢 Ready to approve
The change is narrowly scoped to release publishing configuration and directly addresses the described Central deployment failure without impacting runtime code.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
The Kotlin module has no Java sources, so maven-javadoc-plugin attaches no
javadoc jar to it and Central rejects the whole deployment with
"Javadocs must be provided but not found in entries", which is what
broke the 5.5.1 release. It only exists as a Kotlin interop E2E test,
so keep it out of the published bundle.
But exlcuding all the e2e tests since those does not make sense to publish.