improve: simplify log message for informer re-use - #3583
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
The updated log message labels the value as a “classifier” while logging only a resource identity and also duplicates a method call, which should be clarified and simplified for maintainability.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the informer-pool reuse logging in operator-framework-core to make the “reusing pooled informer” message shorter and easier to read when multiple controllers/event sources share informers.
Changes:
- Simplifies the INFO log message emitted when reusing an existing pooled informer.
- Changes the logged “classifier” representation to a more compact resource identity (resource class or GVK).
File summaries
| File | Description |
|---|---|
| operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPool.java | Streamlines the pooled-informer reuse INFO log output. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gaborgsomogyi
left a comment
There was a problem hiding this comment.
There is a shiny InformerClassifier.toString. If it's not used then what's it's purpose?
Is it still used for debug logging and warning messages. Just I though for this informational purpose is too much noise. |
The atual log message was unnecessary verbose and hard to read / follow.
Signed-off-by: Attila Mészáros a_meszaros@apple.com