Skip to content

improve: simplify log message for informer re-use - #3583

Merged
csviri merged 2 commits into
nextfrom
simplify-log-message
Sep 2, 2026
Merged

improve: simplify log message for informer re-use#3583
csviri merged 2 commits into
nextfrom
simplify-log-message

Conversation

@csviri

@csviri csviri commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

The atual log message was unnecessary verbose and hard to read / follow.

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Copilot AI lite review requested due to automatic review settings September 2, 2026 13:55
@openshift-ci
openshift-ci Bot requested review from metacosm and xstefank September 2, 2026 13:55
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: e12e23f2-e228-4f3a-b92c-01b867eae1fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated log message labels the value as a “classifier” while logging only a resource identity and also duplicates a method call, which should be clarified and simplified for maintainability.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the informer-pool reuse logging in operator-framework-core to make the “reusing pooled informer” message shorter and easier to read when multiple controllers/event sources share informers.

Changes:

  • Simplifies the INFO log message emitted when reusing an existing pooled informer.
  • Changes the logged “classifier” representation to a more compact resource identity (resource class or GVK).
File summaries
File Description
operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPool.java Streamlines the pooled-informer reuse INFO log output.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@gaborgsomogyi gaborgsomogyi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a shiny InformerClassifier.toString. If it's not used then what's it's purpose?

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri

csviri commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

There is a shiny InformerClassifier.toString. If it's not used then what's it's purpose?

Is it still used for debug logging and warning messages. Just I though for this informational purpose is too much noise.

@csviri
csviri merged commit 9ec6702 into next Sep 2, 2026
29 checks passed
@csviri
csviri deleted the simplify-log-message branch September 2, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants