Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Nov 5, 2025

  • kind: v0.30.0
  • kustomize: v5.7.1
  • opm: v1.60.0
  • setup-envtest: capped at v0.0.0-20250620151452-b9a9ca01fd37 (newer commits demand Go ≥ 1.25)

Copilot AI review requested due to automatic review settings November 5, 2025 10:05
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner November 5, 2025 10:05
@openshift-ci openshift-ci bot requested review from dtfranz and perdasilva November 5, 2025 10:05
@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 15bf57d
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/690b267e9ccf550008e68318
😎 Deploy Preview https://deploy-preview-2306--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several development tool dependencies to newer versions, including kustomize, operator-sdk, opm, and their transitive dependencies. The changes also update the Go version requirement to 1.24.6 across multiple module files and remove some dependency replace directives that are no longer needed.

Key changes:

  • Updates kustomize from v5.6.0 to v5.7.1
  • Updates operator-sdk from v1.39.1 to v1.41.1
  • Updates opm from v1.51.0 to v1.60.0
  • Updates Go version from 1.24.0/1.23.x to 1.24.6
  • Removes various replace directives in module files
  • Updates numerous transitive dependencies in sum files

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated no comments.

File Description
.bingo/variables.env Updates tool version variables for kustomize, operator-sdk, and opm
.bingo/Variables.mk Updates makefile variables and build commands for the updated tool versions
.bingo/*.mod Updates Go version to 1.24.6 and removes obsolete replace directives
.bingo/*.sum Updates transitive dependency checksums for the updated tools

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.30%. Comparing base (7c443eb) to head (15bf57d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
+ Coverage   74.23%   74.30%   +0.07%     
==========================================
  Files          90       90              
  Lines        7014     7014              
==========================================
+ Hits         5207     5212       +5     
+ Misses       1398     1394       -4     
+ Partials      409      408       -1     
Flag Coverage Δ
e2e 45.84% <ø> (-0.02%) ⬇️
experimental-e2e 48.20% <ø> (+0.04%) ⬆️
unit 58.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- kind: v0.30.0
- kustomize: v5.7.1
- opm: v1.60.0
- setup-envtest: capped at v0.0.0-20250620151452-b9a9ca01fd37 (newer commits demand Go ≥ 1.25)
@camilamacedo86 camilamacedo86 changed the title 🌱 Replace crd-diff used by official one from k8s sig 🌱 Upgrade compatible bingo binaries ( kind/kustomize/opm/envtest ) Nov 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@echo "(re)installing $(GOBIN)/operator-sdk-v1.39.1"
@cd $(BINGO_DIR) && GOWORK=off $(GO) build -ldflags=-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.34.1 -mod=mod -modfile=operator-sdk.mod -o=$(GOBIN)/operator-sdk-v1.39.1 "github.com/operator-framework/operator-sdk/cmd/operator-sdk"
@echo "(re)installing $(GOBIN)/operator-sdk-v1.41.1"
@cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=operator-sdk.mod -o=$(GOBIN)/operator-sdk-v1.41.1 "github.com/operator-framework/operator-sdk/cmd/operator-sdk"
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operator-sdk build command has removed the -ldflags parameter that was present in the previous version. The original command included -ldflags=-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.34.1 which set a custom version. Please verify if this version flag is still needed for operator-sdk v1.41.1 or if this change is intentional.

Suggested change
@cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=operator-sdk.mod -o=$(GOBIN)/operator-sdk-v1.41.1 "github.com/operator-framework/operator-sdk/cmd/operator-sdk"
@cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=operator-sdk.mod -ldflags="-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.41.1" -o=$(GOBIN)/operator-sdk-v1.41.1 "github.com/operator-framework/operator-sdk/cmd/operator-sdk"

Copilot uses AI. Check for mistakes.
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@tmshort
Copy link
Contributor

tmshort commented Nov 5, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b470947 into operator-framework:main Nov 5, 2025
33 checks passed
@camilamacedo86 camilamacedo86 deleted the crd-diff-bingo-fix branch November 6, 2025 08:04
tmshort added a commit to tmshort/operator-controller that referenced this pull request Nov 6, 2025
@tmshort tmshort mentioned this pull request Nov 6, 2025
4 tasks
openshift-merge-bot bot pushed a commit that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants