Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 6, 2025

This is a fix of #2306 that had an incomplete .bingo update

When running bingo get, bingo was modifying files in the .bingo directory; this is not supposed to happen, bingo get is just supposed to retrieve and build the tools. The opm.mod and operator-sdk.mod files were not updated in #2306, so bingo was attempting to revert changes that were made in #2306.

This also impacted downstreaming, because the bumper runs bingo get, and subsequently, bingo was making changes that the bumper was not expecting, causing the bumper to fail.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner November 6, 2025 22:07
@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit da9d3f0
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/690d1c1acbe99f0008d55a44
😎 Deploy Preview https://deploy-preview-2312--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.29%. Comparing base (9530175) to head (da9d3f0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2312      +/-   ##
==========================================
+ Coverage   74.24%   74.29%   +0.05%     
==========================================
  Files          91       91              
  Lines        7046     7046              
==========================================
+ Hits         5231     5235       +4     
+ Misses       1402     1400       -2     
+ Partials      413      411       -2     
Flag Coverage Δ
e2e 45.91% <ø> (+0.01%) ⬆️
experimental-e2e 48.27% <ø> (+0.06%) ⬆️
unit 58.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025
replace github.com/mattn/go-sqlite3 => github.com/mattn/go-sqlite3 v1.10.0

require github.com/operator-framework/operator-sdk v1.39.1 // cmd/operator-sdk -ldflags=-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.34.1
require github.com/operator-framework/operator-sdk v1.41.1 // cmd/operator-sdk -tags=containers_image_openpgp -ldflags=-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.41.1
Copy link
Contributor

@camilamacedo86 camilamacedo86 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-tags=containers_image_openpgp

Interesting, it be added.

This one I did not updated in that PR because it was not working.
So, probably this flag sorted it out.

@openshift-merge-bot openshift-merge-bot bot merged commit b3f85d5 into operator-framework:main Nov 7, 2025
26 checks passed
@tmshort tmshort deleted the fix-bingo branch November 7, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants