-
Notifications
You must be signed in to change notification settings - Fork 68
🐛 Fix bingo tooling #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix bingo tooling #2312
Conversation
…t ) (operator-framework#2306)" This reverts commit b470947.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2312 +/- ##
==========================================
+ Coverage 74.24% 74.29% +0.05%
==========================================
Files 91 91
Lines 7046 7046
==========================================
+ Hits 5231 5235 +4
+ Misses 1402 1400 -2
+ Partials 413 411 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| replace github.com/mattn/go-sqlite3 => github.com/mattn/go-sqlite3 v1.10.0 | ||
|
|
||
| require github.com/operator-framework/operator-sdk v1.39.1 // cmd/operator-sdk -ldflags=-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.34.1 | ||
| require github.com/operator-framework/operator-sdk v1.41.1 // cmd/operator-sdk -tags=containers_image_openpgp -ldflags=-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.41.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-tags=containers_image_openpgp
Interesting, it be added.
This one I did not updated in that PR because it was not working.
So, probably this flag sorted it out.
b3f85d5
into
operator-framework:main
This is a fix of #2306 that had an incomplete .bingo update
When running
bingo get,bingowas modifying files in the .bingo directory; this is not supposed to happen,bingo getis just supposed to retrieve and build the tools. Theopm.modandoperator-sdk.modfiles were not updated in #2306, sobingowas attempting to revert changes that were made in #2306.This also impacted downstreaming, because the bumper runs
bingo get, and subsequently,bingowas making changes that the bumper was not expecting, causing the bumper to fail.Description
Reviewer Checklist