Skip to content

[release-4.3] Bug 1814263: Make provided API ClusterRoles be owned by the corresponding API. - #1383

Merged
openshift-merge-robot merged 1 commit into
operator-framework:release-4.3from
openshift-cherrypick-robot:cherry-pick-1348-to-release-4.3
Mar 20, 2020
Merged

[release-4.3] Bug 1814263: Make provided API ClusterRoles be owned by the corresponding API.#1383
openshift-merge-robot merged 1 commit into
operator-framework:release-4.3from
openshift-cherrypick-robot:cherry-pick-1348-to-release-4.3

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 17, 2020

Copy link
Copy Markdown

This is an automated cherry-pick of #1348

/assign benluddy

@benluddy openshift-cherrypick-robot
Make provided API ClusterRoles be owned by the corresponding API.
f389682 
The existing CSV owner labels lead to a neverending battle for
ownership in clusters with more than one CSV providing the same
API. The amount of additional work generated by the owner label
conflict manifested (not exclusively) as excessive operator
installation latency in affected clusters.

This conflict is resolved by abandoning CSV owner labels in favor of
OwnerReferences to the providing APIService or
CustomResourceDefinition.

Aggregation of API ClusterRoles to the providing OperatorGroup
ClusterRoles is also changed. Instead of labeling API ClusterRoles
based on the names of OperatorGroups providing the associated API,
each API ClusterRole is labeled based on the name of the API
itself. OperatorGroup ClusterRoles accumulate one label selector per
provided API.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 17, 2020
Merged
5 tasks
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 17, 2020
@openshift-ci-robot

openshift-ci-robot commented Mar 17, 2020

Copy link
Copy Markdown
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1797747, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 1797747 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1797747: Make provided API ClusterRoles be owned by the corresponding API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy benluddy changed the title [release-4.3] Bug 1797747: Make provided API ClusterRoles be owned by the corresponding API. [release-4.3] Bug 1814263: Make provided API ClusterRoles be owned by the corresponding API. Mar 17, 2020
@openshift-ci-robot

openshift-ci-robot commented Mar 17, 2020

Copy link
Copy Markdown
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1814263, which is invalid:

  • expected dependent Bugzilla bug 1809568 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1814263: Make provided API ClusterRoles be owned by the corresponding API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell

ecordell commented Mar 17, 2020

Copy link
Copy Markdown
Member

/bugzilla refresh

@ecordell

ecordell commented Mar 17, 2020

Copy link
Copy Markdown
Member

/retest

@openshift-ci-robot

openshift-ci-robot commented Mar 17, 2020

Copy link
Copy Markdown
Collaborator

@ecordell: This pull request references Bugzilla bug 1814263, which is invalid:

  • expected dependent Bugzilla bug 1809568 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell

ecordell commented Mar 17, 2020

Copy link
Copy Markdown
Member

/retest

@ecordell

ecordell commented Mar 19, 2020

Copy link
Copy Markdown
Member

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 19, 2020
@openshift-ci-robot

openshift-ci-robot commented Mar 19, 2020

Copy link
Copy Markdown
Collaborator

@ecordell: This pull request references Bugzilla bug 1814263, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1809568 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1809568 targets the "4.4.0" release, matching the expected (4.4.0) release
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell

ecordell commented Mar 19, 2020

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@ecordell ecordell mentioned this pull request Mar 19, 2020
Closed
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@benluddy

benluddy commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

/test e2e-gcp-upgrade

@openshift-bot

openshift-bot commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

openshift-bot commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 20, 2020
@openshift-bot

openshift-bot commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot

openshift-bot commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot

openshift-ci-robot commented Mar 20, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, openshift-cherrypick-robot, ravikantcool2019

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit 2cfc21d into operator-framework:release-4.3 Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecordell ecordell Awaiting requested review from ecordell
@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

@benluddy benluddy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @ecordell @benluddy @openshift-bot @mrunalp @openshift-merge-robot