feat(boatstack): capture visual evidence automatically during ship - #255
Merged
Conversation
When the plan declares relevant visual scenarios and the repository registers a capture command, pr-context/check-pr/publish-pr now run the harness themselves whenever evidence is missing or stale — capture is a delivery property, not a prescribed agent step. One hook in PreparePRContext covers all three verbs because publish re-derives the context and staleness co-varies with the fingerprinted product diff. - harness failure degrades to the recorded NOT_VERIFIED gap with a bounded pr_visual_evidence_capture_detail (never a context error, and deliberately outside the context fingerprint) - no registered command → exactly the prior prescribed path - a harness that dirties the working tree is refused with the violating paths (capture contract: write only BOATSTACK_CAPTURE_OUTPUT) - the require publication block is now a calm denial (workflow-visual-evidence-missing) whose solution set enumerates the recovery ladder: capture-evidence, capability-register, provision-capability, record-pr-visual-evidence, planning-write - ship-gate skill text: capturing is no longer the agent's step; its job is the privacy review of the captured PNGs Disclosure-Reviewed: reviewed — public-safe only, private facet kept out of this commit
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pr_visual_evidence: suggestpermitted shipping withNOT_VERIFIEDbecause capture (capture-evidence) and attachment were separate agent-prescribed verbs — in practice the operator had to prompt "attach the screenshot" manually. Invariant enforced by this program: when a delivery declares visual evidence relevant, Boatstack captures and attaches it automatically during ship — or blocks publication. This slice makes capture automatic.What changed
ensureCurrentPRVisualEvidenceinPreparePRContext, between the product diff and evidence resolution.publish-pr → CheckPRPreview → PreparePRContextmeans one hook coverspr-context,check-pr, andpublish-pr; after fix(boatstack): key visual-evidence trust to product identity #254, staleness co-varies with the fingerprinted product diff, so a publish-time-only staleness state is impossible by construction and no second capture site exists.off, plan relevancerelevantwith scenarios, a repository command resolves (project.commands.visual), and evidence is missing or stale. It reusesCaptureEvidencewholesale (supervised per-scenario operations, 3 attempts, fingerprinted reuse).pr_visual_evidence_capture_detailon the context (JSON-only, outside the context fingerprint so a flaky harness message can't destabilize preview equality), resolution proceeds as today. No registered command → exactly the prior prescribed path, runner never consulted. Harness dirties the tree → refused with the violating paths.requireblock inPublishPRis now a calm denial: new categoryworkflow-visual-evidence-missingwith a computed solution set (capture-evidence,capability-register --command <owed>,provision-capability,record-pr-visual-evidence --manifest <owed>,planning-writefor thenot_relevantescape), added to the denial-category inventory so the totality/closure sweeps hold it.visualcapabilityAdmittedStages+=REVIEW_PASSED,PR_PREVIEW(declaration honesty; verified unenforced anywhere).Considered and deliberately unchanged: the statemap
visual-evidenceOwnerVerbs — writes flow through the samecapture-evidencemachinery, matching the existing convention wherepublish-pr's publication-state writes are also not separately declared.Invariants pinned
TestPreparePRContextAutoCapturesRelevantVisualEvidence— declared-relevant evidence is captured by ship, not prescribed; repeat preparation is a no-op per product diff (runner call count and fingerprint stable).TestAutoCaptureFailureDegradesToTodayUnderSuggest— failing harness ⇒ NOT_VERIFIED + bounded detail, no error.TestAutoCaptureUnavailableCapabilityFallsBackToPrescribedPath— zero-value invariant.TestRequiredVisualEvidenceDenialCarriesSolutionSet— blocked publication names its own recovery ladder.Verification
go build ./... && go vet ./... && go test ./...green (incl. denial totality/closure sweeps)2026-07-30-auto-capture-on-ship.mdSlice 2 of 5 (program: visual evidence as a deterministic delivery requirement); follows #254.