Restore suppressing of notifications in groups service#12147
Merged
cbliard merged 1 commit intorelease/12.4from Feb 23, 2023
Merged
Restore suppressing of notifications in groups service#12147cbliard merged 1 commit intorelease/12.4from
cbliard merged 1 commit intorelease/12.4from
Conversation
oliverguenther
force-pushed
the
fix/send-notifications-groups
branch
from
45d9c87 to
447151f
Compare
oliverguenther
requested review from
cbliard and
ulferts
and removed request for
ulferts
cbliard
approved these changes
Feb 23, 2023
Member
cbliard
left a comment
cbliard
left a comment
There was a problem hiding this comment.
It works, but I think some aprts are not necessary, and some other could be clarified or changed so that the send_notifications is managed at the BaseServices::BaseContracted level instead of the BaseServices::Write level, so that BaseServices::Delete and its subclasses can also user send_notifications: false.
Member
|
Will address comments in 12.5. Merging in 12.4 for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_notifications was suppressed for e.g., city of cologne modifying groups through scripts
https://community.openproject.org/wp/46330