Try to make send_notifications more reliable

[cbliard]

It is a follow-up of #12147 where some comments where made about how the send_notifications was used and forwarded to services.

[cbliard]

I think this addresses the comments I had in #12147.

Things that could be considered:

• calling Journal::NotificationConfiguration.with(send_notifications, &) is currently done in Shared::ServiceContext, and is called from BaseServices::BaseContracted#perform by extracting the :send_notifications value from the params hash.
  This could be replaced by a module included with a around_call that would extract the :send_notifications value from params and call Journal::NotificationConfiguration.with(send_notifications, &) directly. This would remove this responsibility from Shared::ServiceContext
• Journal::NotificationConfiguration could be renamed, as it is also used in non-journal places too.
• in config/initializers/subscribe_listeners.rb, there is guard clause next unless payload[:send_notifications] in some of the subscriptions. If all notifiers were consistently using Journal::NotificationConfiguration, then the guard clause could be replaced with next unless Journal::NotificationConfiguration.active? (or next if Journal::NotificationConfiguration.inactive? for a more positive world). There is the question of the notification message being present in the payload. Should it then be carried over in
  Journal::NotificationConfiguration?
• Modify the shared examples 'BaseServices create service' and 'BaseServices update service' to call the service with send_notifications: false and ensure no notification job has been created.

But I'm afraid of going down a rabbit hole if I try to do any of the above propositions.

[oliverguenther]

Looking a lot better already. Thanks 👍