Skip to content

[WIP] [COMMS-876] Single-line/multi-line layout argument for attribute value macros - #24308

Closed
akabiru with Copilot wants to merge 1 commit into
feature/comms-876-adjust-ckeditor-version-macros-single-line-multi-line-layout-argument-for-attribute-value-macrosfrom
copilot/comms-876-single-line-multi-line-layout
Closed

[WIP] [COMMS-876] Single-line/multi-line layout argument for attribute value macros#24308
akabiru with Copilot wants to merge 1 commit into
feature/comms-876-adjust-ckeditor-version-macros-single-line-multi-line-layout-argument-for-attribute-value-macrosfrom
copilot/comms-876-single-line-multi-line-layout

Conversation

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Thanks for the feedback on #24257. I've created this new PR, which merges into #24257, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #24257
Triggering comment (#24257 (comment)):

@copilot The following spec(s) are flaky in CI (first seen on PR #24257, linked for reference only):

  • rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]

Treat this as a standalone task, unrelated to PR #24257. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24257 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. script/bulk_run_rspec --run-count 10).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @akabiru to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR flaky-spec, assign @akabiru, and request a review from @akabiru.
On every commit, set @akabiru as the sole co-author with a Co-authored-by: trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

Copilot AI requested a review from akabiru July 16, 2026 14:12
@akabiru akabiru closed this Jul 17, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 17, 2026
@akabiru
akabiru deleted the copilot/comms-876-single-line-multi-line-layout branch July 17, 2026 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants