WIP Unify queries under target_versions#24368
Draft
brunopagno wants to merge 1 commit into
Draft
Conversation
thykel
reviewed
Jul 22, 2026
| def rewrite_filters | ||
| ActiveRecord::Base.connection.exec_update(<<~SQL.squish) | ||
| UPDATE queries | ||
| SET filters = regexp_replace(filters, '(^|\\n)(:?)version_id:', '\\1\\2target_version_id:', 'g') |
Contributor
There was a problem hiding this comment.
regexp_replace
I'm honestly not too confident about these so far -- if we mess something up, it's gonna be really hard to go back, and the blast radius could theoretically be all users...
The original approach assumed a "compatibility layer" where we internally translated those all version fields to our target_versions. How complex was this? Is the regex really worth it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
I didn't create a ticket yet
What are you trying to accomplish?
Doing some challenging things
Merge checklist