[COMMS-833] Fix asset paths for documents on a relative url#24390
Draft
judithroth wants to merge 1 commit into
Draft
[COMMS-833] Fix asset paths for documents on a relative url#24390judithroth wants to merge 1 commit into
judithroth wants to merge 1 commit into
Conversation
Documents don't work properly with rails relative url https://community.openproject.org/wp/COMMS-833 The documents assets in the shadow root did not respect he relative url, so they were trying to load <base-url>/assets/... instead of loading <base-url>/<relative-url>/assets/...
judithroth
force-pushed
the
bug/comms-833-documents-don-t-work-properly-with-rails-relative-url
branch
from
July 22, 2026 12:45
b12a961 to
9572fd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documents assets in the shadow root did not respect he relative url, so they were trying to load /assets/... instead of loading //assets/...
Ticket
https://community.openproject.org/wp/COMMS-833
What are you trying to accomplish?
Make assets for documents work when
RAILS_RELATIVE_URL_ROOTis set.What approach did you choose and why?
Add a new method
raw_variable_asset_pathwhich has to be used when the rails link helpers (stylesheet_link_tag,javascript_include_tag, etc) are not used.Merge checklist