[XWI-153] Renamed "Internal wiki" → "Project wiki" - #24632
Conversation
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
|
|
||
| > [!NOTE] | ||
| > As of OpenProject 17.6, this setting **does not affect the regular OpenProject Wiki module**. Projects can continue to use their project wiki as usual when the **Wiki** module is enabled under **Project settings → Modules**. This WILL CHANGE in the upcoming releases. We therefore advise to only disable the internal provider, if you are not planning to use internal wikis at all. | ||
| > As of OpenProject 17.6, this setting **does not affect the regular OpenProject Wiki module**. Projects can continue to use their project wiki as usual when the **Wiki** module is enabled under **Project settings → Modules**. This WILL CHANGE in the upcoming releases. We therefore advise to only disable project wikis if you are not planning to use them at all. |
There was a problem hiding this comment.
❗ Outdated
We changed this. Question is whether that change was part of 17.7 or 17.8 (CC @mereghost )
There was a problem hiding this comment.
(also docs below are outdated w.r.t. this)
There was a problem hiding this comment.
To clarify: The whole NOTE box that I commented at here is outdated. As far as I can tell, since 17.7 we now do prevent the creation of project wikis when the global setting is disabled.
Also texts further down on this page here need to be adapted accordingly.
There was a problem hiding this comment.
Yes, I think you are right. This is however the change for 17.7. I'll do it on that (17.7) branch.
|
|
||
| > [!TIP] | ||
| > If the internal wiki provider is disabled by your OpenProject administrator for your instance, this page is not visible and the project wiki cannot be enabled. | ||
| > If project wikis are disabled by your OpenProject administrator for your instance, this page is not visible and the project wiki cannot be enabled. |
There was a problem hiding this comment.
OMG, and I am about to change this behaviour with 17.8, where the settings page remains visible...
So we partially updated our docs, but not completely 🙈
NobodysNightmare
left a comment
There was a problem hiding this comment.
I can't find anything wrong with the changes of this PR, except for the side-find of other docs being outdated (and me being concerned that we'll cause merge conflicts if we fix those).
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
|
Thanks! I'll contact @MayaBerd regarding the docs; we'll cook something up (I hope 😅) |
NobodysNightmare
left a comment
There was a problem hiding this comment.
ah, spotted something I overlooked at first
| one: Inline page link | ||
| other: Inline page links | ||
| wikis/internal_provider: Internal wiki | ||
| wikis/internal_provider: Project wikis |
There was a problem hiding this comment.
This is a very generic translation for wikis/internal_provider. Thus it has to be either:
- always singular
- or properly pluralized
You can look at the surrounding translations for proper pluralization. This also means that if you have places that currently do something like InternalProvider.model_name.human, you might want to replace those with InternalProvider.model_name.human(count: 2).
6e51ee6 to
c15bb53
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
Ticket
XWI-153
What are you trying to accomplish?
Self-titled.
Screenshots
Merge checklist