[OP-19930] Fix lost seeded custom styles when seeding multiple - #24713
Conversation
1a806fe to
3f149cb
Compare
|
Thanks @NobodysNightmare , I changed the order and while doing more tests on the newly deployed cluster, I found the underlying issue: CarrierWave only uploads in an |
Seeding custom design assets from URLs looked as if they were successful (DB was saved with the file name), but the files never made it into fog due to carrierwave having an after_commit hook for storing the file. We update the CustomStyle wiwth save! once per job, and only one of these saves wins the after_commit hook. This matches what we see on the opendesk env. Files are saved in DB, but are not actually present
ccdd738 to
4d9fe3c
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
NobodysNightmare
left a comment
There was a problem hiding this comment.
LGTM, thanks for the detailed explanations
We suspect something is being discarded without proper logging in the seed design background job. Adds more error logging and retrying for HTTP errors
https://community.openproject.org/work_packages/OP-19930