[#697] Presentation 계열 테스트 지원 코드를 target-local로 정리한다#700
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트에서는 TestSupport.swift 파일에서 공통으로 정의되어 있던 테스트 스파이(Spy) 클래스들을 정리하고, 푸시 알림 관련 테스트 스파이들을 신규 파일인 PushNotificationListTestSpies.swift로 분리하여 테스트 코드의 구조를 개선했습니다. 이와 함께 불필요한 임포트 선언과 사용되지 않는 스파이 코드들을 제거하여 전반적인 코드 가독성을 높였습니다. 변경 사항에 대해 추가로 제공할 피드백은 없습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
PresentationSharedTestssupport에 남아 있던 tab/root 전용 spy 제거NotificationTabTests전용 PushNotification spy를 target-local 파일로 분리PresentationShared/Tests/Support/TestSupport.swift를 shared 테스트 공통waitUntil만 남기는 형태로 축소🔍 상세
PushNotificationListTestSpies.swift추가NotificationTabTests에서 사용하는 query/delete/toggle spy를 NotificationTab 테스트 내부로 이동UpsertTodoUseCaseSpy제거PresentationSharedTestssupport의 불필요한 import 제거📸 영상 / 이미지 (Optional)
없음