Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 Firebase Crashlytics 수집 활성화 설정을 기존 코드 제어 방식에서 Xcode 빌드 설정 및 Info.plist 전처리 방식으로 전환하고, Fastlane 빌드 스크립트를 업데이트하는 변경사항을 담고 있습니다. 이에 대한 피드백으로, Info.plist 내에 #if 전처리 지시문을 직접 사용하면 XML 형식이 깨져 PlistBuddy 등에서 파싱 오류가 발생할 수 있으므로 INFOPLIST_KEY_ 설정을 활용할 것을 권장합니다. 또한, Fastlane에서 CRASHLYTICS_COLLECTION_ENABLED 값을 1 대신 YES로 설정하여 Crashlytics가 요구하는 엄격한 Boolean 타입으로 안전하게 컴파일되도록 수정이 필요합니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
🔍 상세
Info.plist에FirebaseCrashlyticsCollectionEnabledBoolean 값 추가CRASHLYTICS_COLLECTION_ENABLED전처리 값에 따른 수집 여부 분리Debug,Staging,Release의 기본값을0과dwarf로 통일FirebaseAppServiceImpl의setCrashlyticsCollectionEnabled(true)호출 제거build_for_store에서CRASHLYTICS_COLLECTION_ENABLED=1과dwarf-with-dsym주입FirebaseCrashlyticsCollectionEnabled=true검증 추가dsym-uuids.txt생성 및 아티팩트 보존 추가✅ 검증
Stagingbuild 성공FirebaseCrashlyticsCollectionEnabled=false확인FirebaseCrashlyticsCollectionEnabled=true확인Fastfile및 workflow YAML 문법 확인📸 영상 / 이미지 (Optional)