Conversation
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 위험한 브랜치 조합에 대한 AI 분석 요청을 조립하기 위해 predictionPairEvidenceBuilder, predictionPairRequestBuilder, predictionPairTargetSelector 모듈 및 관련 타입을 추가하고 테스트 코드를 작성했습니다. 코드 리뷰 결과, 용량 제한(CODE_CONTEXT_MAX_BYTES)으로 인해 일부 hunk만 누락된 파일이 includedFileCount와 omittedFileCount 모두에 중복 집계되는 현상이 발견되어, 완전히 누락된 파일만 정확히 집계하도록 개선할 것을 권장합니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
위험한 branch 조합을 AI 분석 입력의 기본 단위로 정의하고, deterministic 결과와 코드 문맥을 조합별로 격리한 요청 입력 계약 구성.
provider 호출, prompt, response schema와 실패 격리는 #47에서 연결할 수 있도록 책임 범위 분리.
📝 작업 내용
📌 요약
confirmed_conflict조합 항상 포함same_hunk_overlap이 있는potential_overlap조합 포함clean,error, same-file-only overlap 조합 제외baseSnippet,leftSnippet,rightSnippet,mergedSnippet포함🔍 상세
src/ai/predictionPairTargetSelector.ts: AI 분석 대상 branch 조합 선별src/ai/predictionPairEvidenceBuilder.ts: merge 결과와 코드 문맥을 조합별 evidence로 구성src/ai/predictionPairRequestBuilder.ts: 선택된 조합마다 요청 입력 payload 하나씩 조립src/ai/types.ts: branch 조합 evidence와 문맥 집계 타입 추가confirmed_conflictpayload 유지snippet.truncated와 조합 상한에 따른 누락 metadata 분리📸 영상 / 이미지 (Optional)