Disabling hardware TCP segmentation offload doesn't disable VLAN_HWTSO

[GeorgeH005]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• [x ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• [x ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Disabling "hardware TCP segmentation offload" for the parent interface while leaving "Hardware VLAN Filtering" enabled does not disable VLAN_HWTSO

To Reproduce

1. Disable TSO and LRO in the interface settings.
2. Enable VLAN Hardware Filtering
3. Check ifconfig options. VLAN_HWTSO should be included!

Expected behavior
VLAN_HWTSO should have been disabled.

Describe alternatives you considered
Disabling VLAN Hardware Filtering of course disables all related features, including the one in question.
Setting net.inet.tcp.tso=0 should probably mitigate this, but I would like confirmation from someone more knowledgeable than me.

Additional Context

OPNSense is running in a VM in Proxmox but with the intel card passed through. SR-IOV is not being used.

Environment

OPNsense 23.7.11-amd64
FreeBSD 13.2-RELEASE-p7
Network Intel® I350-T2

[GeorgeH005]

To disable using ifconfig, it seems like the command "ifconfig igb0 -vlanhwtso" needs to be run twice. Maybe that has something to do with it?

Edit: Scratch that. It just comes back after a while. Weird behaviour.

[GeorgeH005]

I am reopening this because this behaviour is still exhibited. If this is intended behaviour, or it does not make any functional difference this issue can be closed.

[OPNsense-bot]

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository,
please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.