ui: tabulator: Add _showMaximized() modal that can show a grid close to full screen - #10656
Open
Monviech wants to merge 3 commits into
Open
ui: tabulator: Add _showMaximized() modal that can show a grid close to full screen#10656Monviech wants to merge 3 commits into
Monviech wants to merge 3 commits into
Conversation
move html generation to javascript library, align model a bit differently and always stretch to page height to remove distractions while reading. includes some smaller fixes for missing tooltips and "hanging" tooltips as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
On smaller viewports like 1080p monitors or mobile devices, all the cruft around the grid can starve the actual grid for most available space.
On large screens you also generically profit from this, as you can see more rows and fill your whole screen with more information.
Describe the proposed solution
The maximize grid button opens a modal that contains the grid. It uses as much space as possible, and improves interaction on touch devices as there are no sticky headers or columns anymore.
The modal itself is always below dialogs, so you can interact normally and add new rows.
This makes pages like the Firewall actually usable on screens as small as a normal iPhone without a hazzle.
Related issue
Fixes: #10130