WIP dns/dyndns: tidy up code and add new service type Custom (v4/v6) to allow updating A and AAAA in one URL - #2053
Closed
Starkstromkonsument wants to merge 19 commits into
Closed
Conversation
Starkstromkonsument
force-pushed
the
dynds_custom
branch
from
October 4, 2020 00:42
b05b31f to
b0dd949
Compare
This was referenced Oct 10, 2020
… some sanitation to user variables and add more verbose logging
- cacheTimeIPv4 and cahceTimeIPv6 were not checked correctly, when only one IPv4 or IPv6 was enabled - there is no need to set _forceUpdateNeeded - added timestamps of last update to verbose logging
Contributor
Author
|
I did not find any function to convert a bool to its string representation. If I missed something, please give me a hint and I'll be happy to use the existing function and remove my new one. THX |
Member
|
@Starkstromkonsument question is if it really matters if it's a bool, usually the only question is if it would render to "true", in which case I would use something like this |
Contributor
Author
|
I guess keeping this PR open any longer does not make much sense. If I get this all right, developing a new plugin for ddclient would be the proper way to fix this. IPv6 support seems to be a current task for ddclient 4.0 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.