Skip to content

WIP dns/dyndns: tidy up code and add new service type Custom (v4/v6) to allow updating A and AAAA in one URL - #2053

Closed
Starkstromkonsument wants to merge 19 commits into
opnsense:masterfrom
Starkstromkonsument:dynds_custom
Closed

WIP dns/dyndns: tidy up code and add new service type Custom (v4/v6) to allow updating A and AAAA in one URL#2053
Starkstromkonsument wants to merge 19 commits into
opnsense:masterfrom
Starkstromkonsument:dynds_custom

Conversation

@Starkstromkonsument

@Starkstromkonsument Starkstromkonsument commented Oct 4, 2020

Copy link
Copy Markdown
Contributor

@Starkstromkonsument Starkstromkonsument changed the title dns/dyndns: add new service type Custom (v4/v6) to allow updating A and AAAA in one URL and some code maintenance WIP dns/dyndns: tidy up code and add new service type Custom (v4/v6) to allow updating A and AAAA in one URL Oct 10, 2020
… some sanitation to user variables and add more verbose logging
- cacheTimeIPv4 and cahceTimeIPv6 were not checked correctly, when only one IPv4 or IPv6 was enabled
- there is no need to set _forceUpdateNeeded
- added timestamps of last update to verbose logging
@Starkstromkonsument

Copy link
Copy Markdown
Contributor Author

I did not find any function to convert a bool to its string representation. If I missed something, please give me a hint and I'll be happy to use the existing function and remove my new one. THX

@AdSchellevis

Copy link
Copy Markdown
Member

@Starkstromkonsument question is if it really matters if it's a bool, usually the only question is if it would render to "true", in which case I would use something like this !empty($var) ? "true" : "false" (or simpler, only log 0/1 using the same type of construct (int)!empty($var))

@Starkstromkonsument

Copy link
Copy Markdown
Contributor Author

I guess keeping this PR open any longer does not make much sense. If I get this all right, developing a new plugin for ddclient would be the proper way to fix this. IPv6 support seems to be a current task for ddclient 4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

dns/dyndns custom service types: include current AAAA or A record in update URL dyndns result matching

2 participants