net/frr: add per-neighbor local-as option for BGP#5308
net/frr: add per-neighbor local-as option for BGP#5308Monviech merged 2 commits intoopnsense:masterfrom
Conversation
|
I guess this looks fine and the change is minimal. The question is how often is this needed. The frr plugin exists since years and you seem to be the first one who misses this. How common is that migration szenario you are describing? (I don't have a lot of (practical) bgp experience)) There are so many options in the plugin already, we have to be careful to be selective at this point. |
Thanks for taking a look. You’re right that it’s not a common configuration, which is probably why it hasn’t come up before. However, it is a standard BGP feature used in scenarios like ASN migrations or when peering with providers that require a specific ASN. For example, with AWS Direct Connect it’s fairly common to run a private ASN internally but present a different ASN to AWS using local-as at the neighbor level. FRR already supports this natively; the PR simply exposes that existing option in the plugin UI. Since it’s optional and only used when explicitly configured, it shouldn’t affect normal setups. |
|
That sounds good enough for me. Thank you. Can you bump the minor version in the Makefile and add a changelog to pkg-descr in the style of the other changelogs (contributed by and the pull request link) Please also do a PR to add this to the documentation here (just the option is enough) |
|
Seperate docs PR done 🙂 |
|
Merged, thank you :) |
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Related issue
If this pull request relates to an issue, link it here:
closes #5307
Describe the problem
The FRR plugin currently does not allow setting a BGP
local-ason a per-neighbor basis. This blocks common interoperability/migration scenarios where a specific peer requires a different local AS than the router’s global BGP AS.Describe the proposed solution
This pull request adds neighbor-level
local-assupport in the FRR plugin:localasto the BGP neighbor model (IntegerField, range1..4294967295)Local ASfield to the BGP neighbor edit dialogneighbor <address> local-as <asn>inbgpd.confwhen configuredThe change is backward compatible: no
local-ascommand is emitted unless explicitly configured for a neighbor.