net/frr: add BGP maximum-paths support for ECMP multipath#5340
Merged
Monviech merged 1 commit intoopnsense:masterfrom Mar 27, 2026
Merged
net/frr: add BGP maximum-paths support for ECMP multipath#5340Monviech merged 1 commit intoopnsense:masterfrom
Monviech merged 1 commit intoopnsense:masterfrom
Conversation
Member
|
Don't delete the PR template. |
|
Would love to see this merged! Am hacking my config files to accomplish this right now, which I deeply dislike. @maxfield-allison you have merge conflicts 🙁 |
maxfield-allison
force-pushed
the
feature/bgp-maximum-paths
branch
from
ecb3bb4 to
7acfc33
Compare
Contributor
Author
|
Should be good to merge now. |
Member
|
I'll give it a look this or next week. Thanks. Would also need docs like the other PR you referenced. |
Monviech
requested changes
Mar 26, 2026
Member
Monviech
left a comment
Monviech
left a comment
There was a problem hiding this comment.
Looks good, just some general nitpicks.
To merge this, a docs PR is a requirement to update the new fields in it. It's not a requirement to explain how to use this (well, you could if you feel generous :)
net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/bgp.xml
Outdated
Show resolved
Hide resolved
net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/bgp.xml
Outdated
Show resolved
Hide resolved
maxfield-allison
force-pushed
the
feature/bgp-maximum-paths
branch
from
7acfc33 to
bf424af
Compare
Contributor
Author
|
Thanks for the review @Monviech. Applied all four suggestions and force-pushed. Docs PR: opnsense/docs#864 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Related issue
Resolves #4878
Describe the problem
BGP
maximum-pathsandmaximum-paths ibgpcannot be configured through the OPNsense GUI. Users must apply these settings viavtyshdirectly, which are then lost whenever the GUI "Apply" button is clicked and FRR regenerates its configuration.Describe the proposed solution
Adds
maximum-pathsandmaximum-paths ibgpsupport to the BGP address-family configuration, enabling ECMP multipath for both EBGP and IBGP peers.Changes:
BGP.xml): two optionalIntegerFields (range 1–128) afterbestpathbgp.xml): two advanced-mode fields on the BGP General tabbgpd.conf): rendersmaximum-paths [ibgp] Ninside the address-family loopFollows the same pattern as the
local-asaddition in #5308.