Respect closed default panels#32
Merged
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c3142b96-4b3a-4342-ae99-79c455a87ed5) |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
atelier-preview | 0635f04 | Commit Preview URL Branch Preview URL |
Jul 14 2026, 05:27 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultOpenPanelslistWhy
The layout size recovery expanded a zero-width left panel even when the host explicitly configured the panel to start closed. This made host-level document modes unable to present a focused, panel-free initial view.
Impact
Hosts can now reliably use
defaultOpenPanels: []; users can still reopen either panel with the existing controls.Validation
pnpm exec vitest run src/create-atelier.test.tsx— 5 passedpnpm run typecheckpnpm exec oxfmt --check src/create-atelier.test.tsx src/shell/layout-shell.tsxoxlinton both changed filesNote
Low Risk
Small conditional change in layout sizing plus test coverage; no auth, data, or API surface changes.
Overview
Hosts can use
defaultOpenPanels: []withfilesViewMode: "sidebar"and get a document-focused layout without side panels opening on their own.layout-shell.tsxonly applies the sidebar minimum-width recovery (bumping a near-zero left size back to the default left width) when the left panel is meant to open by default (defaultLeftPanelOpen). Previously that recovery ran whenever stored left width was collapsed, which overrode an explicit “start closed” host config.A regression test in
create-atelier.test.tsxopens a file with both panels collapsed and asserts the left/right toggle buttons stayaria-pressed="false"after the document loads.Reviewed by Cursor Bugbot for commit 0635f04. Bugbot is set up for automated code reviews on this repo. Configure here.