This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Conversation
acunniffe
reviewed
Jan 2, 2024
|
|
||
| test('with nullable', async () => { | ||
| // nullable keyword only valid in 3.0.1 | ||
| if (version !== '3.0.1') return; |
Member
There was a problem hiding this comment.
I believe it's valid in 3.0.0 and 3.0.1
acunniffe
approved these changes
Jan 2, 2024
Member
acunniffe
left a comment
acunniffe
left a comment
There was a problem hiding this comment.
Looks good -- let's get this out and back to them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍗 Description
What does this PR do? Anything folks should know?
fixes the case where nullable is next to a polymorphic keyword (allOf, oneOf, anyOf)
📚 References
Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.
👹 QA
How can other humans verify that this PR is correct?