[FSSDK-12097] refactor OptimizelyUserContext tests using TS and vitest #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors the OptimizelyUserContext test suite from JavaScript (using Chai/Sinon) to TypeScript with vitest. The refactoring modernizes the test infrastructure while maintaining comprehensive test coverage for user context functionality including attribute management, decision-making, forced decisions, and segment qualification.
Key Changes
- Migrated from Chai assertions to vitest's
expectAPI - Replaced Sinon mocks with vitest's
vi.fn()mocking utilities - Updated mock helpers to use TypeScript types and standardized mock functions (
getMockLogger,getMockEventDispatcher) - Removed deprecated parameters (
shouldIdentifyUser,isValidInstance,eventBatchSize) that are no longer part of the API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
junaed-optimizely
approved these changes
Dec 5, 2025
Contributor
junaed-optimizely
left a comment
junaed-optimizely
left a comment
There was a problem hiding this comment.
Looks good! For completeness, we can add tests for the async variants as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues