Skip to content

Conversation

@mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented May 26, 2020

Summary

  • Add missing definition for getFeatureVariable
  • Fix return type for getAllFeatureVariables

Test plan

Manually tested

@mjc1283 mjc1283 requested a review from a team as a code owner May 26, 2020 16:20
@mjc1283 mjc1283 removed their assignment May 26, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.746% when pulling 454432c on mcarroll/fix-ts-defs-get-feature-variable into 58b5412 on master.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit cdfbe43 into master May 27, 2020
@mjc1283 mjc1283 deleted the mcarroll/fix-ts-defs-get-feature-variable branch May 27, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants