fix: Stub event dispatcher and mock timers in tests #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 29, 2020 14:17
mjc1283
commented
Jun 2, 2020
Comment on lines
-169
to
-181
| it('should allow passing of "react-sdk" as the clientEngine', function() { | ||
| var optlyInstance = optimizelyFactory.createInstance({ | ||
| clientEngine: 'react-sdk', | ||
| datafile: {}, | ||
| errorHandler: fakeErrorHandler, | ||
| eventDispatcher: fakeEventDispatcher, | ||
| logger: silentLogger, | ||
| }); | ||
| // Invalid datafile causes onReady Promise rejection - catch this error | ||
| optlyInstance.onReady().catch(function() {}); | ||
| assert.equal('react-sdk', optlyInstance.clientEngine); | ||
| }); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Deleted this because it's identical to the test above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
setTimeoutusingsinon.useFakeTimersnockmock for this to prevent the real request.Test plan
Run
npm test. Should exit immediately, and not make any outgoing HTTP requests.Issues
#487