refactor: Move Async Storage Implementation to utils package #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
suggested changes
Jun 9, 2020
Contributor
mjc1283
left a comment
mjc1283
left a comment
There was a problem hiding this comment.
LGTM. Please add an entry under "Unreleased", "New features" packages/utils/CHANGELOG.md.
mjc1283
approved these changes
Jun 10, 2020
mjc1283
suggested changes
Jun 11, 2020
packages/utils/package.json
Outdated
| "dependencies": { | ||
| "uuid": "^3.3.2" | ||
| "uuid": "^3.3.2", | ||
| "@optimizely/js-sdk-logging": "^0.1.0" |
Contributor
There was a problem hiding this comment.
I realized that this will create a circular dependency between our logging and utils packages. Please remove logging from the utils package.
mjc1283
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is first PR in an effort to implement support for Offline Events persistence for React Native Apps. Async Storage implementation was already done in
datafile-managerpackage to support datafile caching. This PR moves the generic caching implementation toutilsso that it can be used by bothdatafile-managerandevent-processor.Test plan
All Existing tests should pass