-
Notifications
You must be signed in to change notification settings - Fork 83
[FSSDK-9987] fix: Conditional ODP instantiation #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Developer review completed. |
jaeopt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We need to double check of its side-effects.
For example -
javascript-sdk/lib/optimizely/index.ts
Line 1761 in 961f6a1
| this.logger.error(ERROR_MESSAGES.ODP_FETCH_QUALIFIED_SEGMENTS_FAILED_ODP_MANAGER_MISSING); |
They do not want to see many "ERROR"-level logging. Better stay silent except for "ODP disabled" at the init phase.
This is an EXCELLENT catch @jaeopt. Thanks. Let me comb through and find these scenarios. |
Also remove some throws & linting
|
Temp close |
Summary
odpOptions.disabled = trueis passed, avoid ODP instantiationTest plan
Issues